Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on pub extern crate. #28486

Merged
merged 1 commit into from
Sep 19, 2015
Merged

Warn on pub extern crate. #28486

merged 1 commit into from
Sep 19, 2015

Conversation

nrc
Copy link
Member

@nrc nrc commented Sep 18, 2015

Temporary 'fix' for #26775

r? @brson

@nrc nrc added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 18, 2015
@alexcrichton
Copy link
Member

@bors: r+ 269c59d

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 18, 2015
@bors
Copy link
Contributor

bors commented Sep 19, 2015

⌛ Testing commit 269c59d with merge d97be7b...

bors added a commit that referenced this pull request Sep 19, 2015
@bors
Auto merge of #28486 - nrc:pub-extern-crate, r=alexcrichton
d97be7b 
Temporary 'fix' for #26775

r? @brson
@bors
Copy link
Contributor

bors commented Sep 19, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 269c59d into rust-lang:master Sep 19, 2015
@alexcrichton alexcrichton added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Sep 23, 2015
@pnkfelix
Copy link
Member

@rust-lang/lang I have no opinion about backporting this to beta; I certainly don't object, but I also don't think its the end of the world if we end up waiting a release cycle for this warning.

@nikomatsakis
Copy link
Contributor

Same. It's a very small patch, so relatively harmless.

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 16, 2015
@nikomatsakis
Copy link
Contributor

Given that @nrc nominated it, i'm going to assume he's in favor.

@brson brson mentioned this pull request Oct 16, 2015
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 16, 2015
@nrc
Copy link
Member Author

nrc commented Oct 18, 2015

I nominated this at the start of the cycle, I'd not be in favour at this point, but it looks like I'm too late - no harm though.

@durka durka mentioned this pull request Mar 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nrc @alexcrichton @bors @pnkfelix @nikomatsakis @brson