-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Change rustdoc header anchor rendering #28499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Looks like a few temporary files made their way in by accident? Could those be removed? |
Yeah, my bad, I'm on it. |
@@ -0,0 +1,2165 @@ | |||
% Error Handling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be in here
Oops, just saw the other comments now. This looks good to me if @alexcrichton is happy with it, and with that stuff removed |
41d6d87
to
324dae5
Compare
Done, temp files are gone! |
Thanks! Can you be sure to add some rustdoc tests for these? It'd be good to ensure we don't regress generating anchors for weird titles like |
Added test |
@bors: r+ |
📌 Commit 5b4cccc has been approved by |
@semmaz yeah that test is fine, thanks! |
☔ The latest upstream changes (presumably #28516) made this pull request unmergeable. Please resolve the merge conflicts. |
5b4cccc
to
09c1ce1
Compare
@steveklabnik rebased. Retry? |
@bors: r+ |
📌 Commit 09c1ce1 has been approved by |
This changes how rustic generate `id` and `href` attributes for section header anchor. Now they are more github-like. Also fixes breakage in docs caused by this and broken links in "Error Handling" section of book. r? @steveklabnik cc @alexcrichton
This changes how rustdoc generate
id
andhref
attributes for section header anchor. Now they are more github-like.Also fixes breakage in docs caused by this and broken links in "Error Handling" section of book.
r? @steveklabnik
cc @alexcrichton