Skip to content

Change syntax::ast_util::stmt_id to not panic on macros #28577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2015

Conversation

jethrogb
Copy link
Contributor

This enables the Debug trait to work on syntax::ast::Stmt.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

This enables the Debug trait to work on syntax::ast::Stmt
@jethrogb jethrogb force-pushed the topic/ast-stmt-debug branch from 0afc2bf to 0a2ffa0 Compare September 21, 2015 23:54
@jethrogb
Copy link
Contributor Author

Updated for line-length lint.

@pcwalton
Copy link
Contributor

pcwalton commented Oct 1, 2015

@bors: r+

@bors
Copy link
Collaborator

bors commented Oct 1, 2015

📌 Commit 0a2ffa0 has been approved by pcwalton

@pcwalton
Copy link
Contributor

pcwalton commented Oct 1, 2015

Sorry this has taken so long.

bors added a commit that referenced this pull request Oct 1, 2015
This enables the Debug trait to work on syntax::ast::Stmt.
@bors
Copy link
Collaborator

bors commented Oct 1, 2015

⌛ Testing commit 0a2ffa0 with merge 031dd9c...

@bors bors merged commit 0a2ffa0 into rust-lang:master Oct 1, 2015
@jethrogb jethrogb deleted the topic/ast-stmt-debug branch October 1, 2015 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants