Simplify on_panic callback handling #28585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The registration of `panicking::on_panic` as a general-purpose callback is overcomplicated and can fail. Instead, invoking it explicitly removes the need for locking and paves the way for further improvements.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Actually while you're at it, could you remove the Thanks for the cleanups! |
|
Wow, I dod not expect that to already be possible, but I'm very glad to do that. More patches incoming :) |
The `register` function is unstable and it is not used anymore, hence it can be removed (together with the now-unused `Callback` type and `static` variables).
|
I updated this PR. I'll make another one soon to make panicking more robust (in particular, to make sure that if |
bors
added a commit
that referenced
this pull request
Sep 23, 2015
This is part of some cleanup I did while investigating #28129. This also ensures that `on_panic` is run even if the user has registered too many callbacks.
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Nov 9, 2023
It was added way back in rust-lang#28585 under the name `-Zkeep-mtwt-tables`. The justification was: > This is so that the resolution results can be used after analysis, > potentially for tool support. There are no uses of significance in the code base, and various Google searches for both option names (and variants) found nothing of interest. I think this can safely be removed.
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Nov 10, 2023
It was added way back in rust-lang#28585 under the name `-Zkeep-mtwt-tables`. The justification was: > This is so that the resolution results can be used after analysis, > potentially for tool support. There are no uses of significance in the code base, and various Google searches for both option names (and variants) found nothing of interest. @petrochenkov says removing this part (and it's only part) of the hygiene data is dubious. It doesn't seem that big, so let's just keep it around.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 10, 2023
…=<try> Remove `-Zkeep-hygiene-data`. It was added way back in rust-lang#28585 under the name `-Zkeep-mtwt-tables`. The justification was: > This is so that the resolution results can be used after analysis, > potentially for tool support. There are no uses of significance in the code base, and various Google searches for both option names (and variants) found nothing of interest. I think this can safely be removed. r? `@davidtwco`
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Nov 13, 2023
… r=petrochenkov Remove `-Zkeep-hygiene-data`. It was added way back in rust-lang#28585 under the name `-Zkeep-mtwt-tables`. The justification was: > This is so that the resolution results can be used after analysis, > potentially for tool support. There are no uses of significance in the code base, and various Google searches for both option names (and variants) found nothing of interest. I think this can safely be removed. r? `@davidtwco`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
Rollup merge of rust-lang#117737 - nnethercote:rm-Zkeep-hygiene-data, r=petrochenkov Remove `-Zkeep-hygiene-data`. It was added way back in rust-lang#28585 under the name `-Zkeep-mtwt-tables`. The justification was: > This is so that the resolution results can be used after analysis, > potentially for tool support. There are no uses of significance in the code base, and various Google searches for both option names (and variants) found nothing of interest. I think this can safely be removed. r? `@davidtwco`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of some cleanup I did while investigating #28129.
This also ensures that
on_panicis run even if the user has registered too many callbacks.