std: Update MatchIndices to return a subslice #28632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gankro (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
update-match-indices
branch
from
b4e2b72 to
be634e4
Compare
This commit updates the `MatchIndices` and `RMatchIndices` iterators to follow the same pattern as the `chars` and `char_indices` iterators. The `matches` iterator currently yield `&str` elements, so the `MatchIndices` iterator now yields the index of the match as well as the `&str` that matched (instead of start/end indexes). cc rust-lang#27743
alexcrichton
force-pushed
the
update-match-indices
branch
from
be634e4 to
d5f2d3b
Compare
|
@bors: r=Kimundi |
|
📌 Commit d5f2d3b has been approved by |
bors
added a commit
that referenced
this pull request
Sep 26, 2015
This commit updates the `MatchIndices` and `RMatchIndices` iterators to follow the same pattern as the `chars` and `char_indices` iterators. The `matches` iterator currently yield `&str` elements, so the `MatchIndices` iterator now yields the index of the match as well as the `&str` that matched (instead of start/end indexes). cc #27743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
MatchIndicesandRMatchIndicesiterators to followthe same pattern as the
charsandchar_indicesiterators. Thematchesiterator currently yield
&strelements, so theMatchIndicesiterator nowyields the index of the match as well as the
&strthat matched (instead ofstart/end indexes).
cc #27743