Skip to content

remove a sentence #28701 #28705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2015
Merged

remove a sentence #28701 #28705

merged 2 commits into from
Sep 29, 2015

Conversation

marti1125
Copy link
Contributor

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Thanks so much!

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 28, 2015

📌 Commit e1acf87 has been approved by steveklabnik

@steveklabnik
Copy link
Member

(Oh, and in the future, if you say "Fixes #28701" in your commit message, rather than just the number, GitHub will automatically close the issue when the PR is merged.

@marti1125
Copy link
Contributor Author

@steveklabnik ok =D

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 28, 2015

📌 Commit 7f9c4aa has been approved by steveklabnik

@steveklabnik
Copy link
Member

(I'm working with @marti1125 on IRC right now, and so I told them this is okay, and they'll make new PRs in the future)

bors added a commit that referenced this pull request Sep 28, 2015
@bors
Copy link
Collaborator

bors commented Sep 28, 2015

⌛ Testing commit 7f9c4aa with merge 6108e8c...

@bors bors merged commit 7f9c4aa into rust-lang:master Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants