Improve identifier defintion in the reference #28764
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
force-pushed
the
gh28706
branch
from
7cf9e53 to
ecc512b
Compare
| * The remaining characters have property `XID_continue` | ||
| Or | ||
| * The first character is `_` | ||
| * The remaining characters have property `XID_continue` |
There was a problem hiding this comment.
Is _ by itself an identifier?
There was a problem hiding this comment.
It is not. Should I be more explicit that there must be more than zero 'remaining characters' here?
|
r=me with a clarification of there must be some remaining characters for |
steveklabnik
force-pushed
the
gh28706
branch
from
ecc512b to
2a787a2
Compare
|
@bors: r=alexcrichton rollup |
|
📌 Commit 2a787a2 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Sep 30, 2015
Fixes rust-lang#28706 I am pretty sure that this is accurate, bout would love a double check.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Sep 30, 2015
Fixes rust-lang#28706 I am pretty sure that this is accurate, bout would love a double check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28706
I am pretty sure that this is accurate, bout would love a double check.