Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a --dep-file option #28767

Closed
wants to merge 1 commit into from
Closed

Conversation

froydnj
Copy link
Contributor

@froydnj froydnj commented Sep 30, 2015

Some projects need/want finer-grained control over where dependency
information is generated, rather than accepting the rustc default. For
those projects, add a --dep-file option which enables them to specify
the location of the dependency info file. It looks like config::Options
had such support already, so all that needs to be done is adding the
appropriate option and stuffing the information into the options
structure.

Fixes #28716.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@froydnj
Copy link
Contributor Author

froydnj commented Sep 30, 2015

It's worth noting that src/librustc_driver/driver.rs:write_out_deps references a --dep-file option, so perhaps one was present in the past, and got removed in some code shuffling?

@froydnj
Copy link
Contributor Author

froydnj commented Sep 30, 2015

Looks like #28768 overlaps this pull request and does a better job, so closing this one in favor of that.

@froydnj froydnj closed this Sep 30, 2015
@froydnj froydnj deleted the dependency-info-file branch September 30, 2015 19:05
Some projects need/want finer-grained control over where dependency
information is generated, rather than accepting the rustc default.  For
those projects, add a --dep-file option which enables them to specify
the location of the dependency info file.  It looks like config::Options
had such support already, so all that needs to be done is adding the
appropriate option and stuffing the information into the options
structure.

Fixes rust-lang#28716.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants