-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename categorization and stop re-exporting its variants. #28846
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
We may want to do some re-categorization as part of the MIR work. r? @pnkfelix |
☔ The latest upstream changes (presumably #29327) made this pull request unmergeable. Please resolve the merge conflicts. |
@Ms2ger unfortunately I let this sit in my review queue so long that it has become invalidated. As a refactoring it seems fine, but @arielb1 is right to wonder if the mem-categorization code may well change with the coming MIR changes... anyway, it is lgtm as it is. if @Ms2ger rebases, I can re-review. Seems relatively harmless either way, up to you. |
f0fe886
to
9e135f7
Compare
@pnkfelix r? |
My expectation is that mem-categorization will largely go away, but I think it's fine to refactor it. |
@bors r+ |
📌 Commit 9e135f7 has been approved by |
No description provided.