Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename categorization and stop re-exporting its variants. #28846

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 5, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented Oct 5, 2015

We may want to do some re-categorization as part of the MIR work.

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned arielb1 Oct 5, 2015
@bors
Copy link
Contributor

bors commented Oct 27, 2015

☔ The latest upstream changes (presumably #29327) made this pull request unmergeable. Please resolve the merge conflicts.

@pnkfelix
Copy link
Member

@Ms2ger unfortunately I let this sit in my review queue so long that it has become invalidated.

As a refactoring it seems fine, but @arielb1 is right to wonder if the mem-categorization code may well change with the coming MIR changes...

anyway, it is lgtm as it is. if @Ms2ger rebases, I can re-review. Seems relatively harmless either way, up to you.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 29, 2015

@pnkfelix r?

@nikomatsakis
Copy link
Contributor

My expectation is that mem-categorization will largely go away, but I think it's fine to refactor it.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 2, 2015

📌 Commit 9e135f7 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Nov 2, 2015

⌛ Testing commit 9e135f7 with merge 5b11b28...

@bors bors merged commit 9e135f7 into rust-lang:master Nov 2, 2015
@Ms2ger Ms2ger deleted the categorization branch December 30, 2015 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants