Skip to content

Run rustfmt on libarena. #28990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Run rustfmt on libarena. #28990

merged 1 commit into from
Oct 14, 2015

Conversation

ahmedcharles
Copy link
Contributor

No description provided.

@ahmedcharles
Copy link
Contributor Author

r? @nrc

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive assigned nrc and unassigned nikomatsakis Oct 12, 2015
@@ -297,7 +290,8 @@ impl<'longer_than_self> Arena<'longer_than_self> {

unsafe {
let buf = head.as_ptr();
(buf.offset(tydesc_start as isize), buf.offset(start as isize))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange, it looks like it fits in 100 columns.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a heuristic where we cut off into vertical formatting before we hit the absolute limit. We probably shouldn't do it for tuples though (only for function calls).

https://github.com/nrc/rustfmt/issues/450

@nrc
Copy link
Member

nrc commented Oct 13, 2015

@bors: r+ rollup

Thanks for the PR!

@bors
Copy link
Collaborator

bors commented Oct 13, 2015

📌 Commit 21bb0dc has been approved by nrc

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 13, 2015
bors added a commit that referenced this pull request Oct 14, 2015
@bors bors merged commit 21bb0dc into rust-lang:master Oct 14, 2015
@ahmedcharles ahmedcharles deleted the libarena branch February 26, 2016 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants