-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Document a bunch of std::iter traits #29065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
/// // You can extend a String with some chars: | ||
/// let mut message = String::from("The first three letters are: "); | ||
/// | ||
/// message.extend(['a', 'b', 'c'].iter()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may even be able to be &['a', 'b', 'c']
as &[T; 3]
implements IntoIterator
19ec881
to
cb5dc4c
Compare
@@ -1 +1 @@ | |||
Subproject commit cde1ed3196ba9b39bcf028e06e08a8722113a5cb | |||
Subproject commit 62ad301a2407a7aca50c1d5120c63597d676d29f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eff, yes. fixing
76b4ced
to
b124a88
Compare
@alexcrichton thanks for your patience. I think this should be good now. 👍 |
/// A type growable from an `Iterator` implementation | ||
/// Extend a collection with the contents of an iterator. | ||
/// | ||
/// Iterators produce a series of values, and collections can also be though of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/be though of/be thought of as/
@bors: r+ b124a88b50e6c2467d60294799fceb792c23b8f8 Of course, and thanks as always @steveklabnik! |
@bors: r- er well r=me after typos found by @apasel422 |
📌 Commit b124a88 has been approved by |
Hehe, I should just cc @apasel422 on every one of my PRs. He always spots a few 😄 |
b124a88
to
1c08532
Compare
@bors: r=alexcrichton |
📌 Commit 1c08532 has been approved by |
⌛ Testing commit 1c08532 with merge 802cd3c... |
💔 Test failed - auto-mac-64-nopt-t |
1c08532
to
608cb84
Compare
This adds a bunch of documentation for most of the traits in std::iter
How embarassing. @bors: r=alexcrichton |
📌 Commit 608cb84 has been approved by |
This adds a bunch of documentation for most of the traits in std::iter
This adds a bunch of documentation for most of the traits in std::iter