Skip to content

Document a bunch of std::iter traits #29065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2015

Conversation

steveklabnik
Copy link
Member

This adds a bunch of documentation for most of the traits in std::iter

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

/// // You can extend a String with some chars:
/// let mut message = String::from("The first three letters are: ");
///
/// message.extend(['a', 'b', 'c'].iter());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may even be able to be &['a', 'b', 'c'] as &[T; 3] implements IntoIterator

@steveklabnik steveklabnik force-pushed the doc_iter_traits branch 3 times, most recently from 19ec881 to cb5dc4c Compare October 23, 2015 00:38
@@ -1 +1 @@
Subproject commit cde1ed3196ba9b39bcf028e06e08a8722113a5cb
Subproject commit 62ad301a2407a7aca50c1d5120c63597d676d29f
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eff, yes. fixing

@steveklabnik steveklabnik force-pushed the doc_iter_traits branch 5 times, most recently from 76b4ced to b124a88 Compare October 23, 2015 17:57
@steveklabnik
Copy link
Member Author

@alexcrichton thanks for your patience. I think this should be good now. 👍

/// A type growable from an `Iterator` implementation
/// Extend a collection with the contents of an iterator.
///
/// Iterators produce a series of values, and collections can also be though of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/be though of/be thought of as/

@alexcrichton
Copy link
Member

@bors: r+ b124a88b50e6c2467d60294799fceb792c23b8f8

Of course, and thanks as always @steveklabnik!

@alexcrichton
Copy link
Member

@bors: r- er well r=me after typos found by @apasel422

@bors
Copy link
Collaborator

bors commented Oct 23, 2015

📌 Commit b124a88 has been approved by me

@steveklabnik
Copy link
Member Author

Hehe, I should just cc @apasel422 on every one of my PRs. He always spots a few 😄

@steveklabnik
Copy link
Member Author

@bors: r=alexcrichton

@bors
Copy link
Collaborator

bors commented Oct 23, 2015

📌 Commit 1c08532 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Oct 23, 2015

⌛ Testing commit 1c08532 with merge 802cd3c...

@bors
Copy link
Collaborator

bors commented Oct 23, 2015

💔 Test failed - auto-mac-64-nopt-t

This adds a bunch of documentation for most of the traits in std::iter
@steveklabnik
Copy link
Member Author

How embarassing.

@bors: r=alexcrichton

@bors
Copy link
Collaborator

bors commented Oct 23, 2015

📌 Commit 608cb84 has been approved by alexcrichton

bors added a commit that referenced this pull request Oct 23, 2015
This adds a bunch of documentation for most of the traits in std::iter
@bors
Copy link
Collaborator

bors commented Oct 23, 2015

⌛ Testing commit 608cb84 with merge 525ab4a...

@bors bors merged commit 608cb84 into rust-lang:master Oct 23, 2015
@steveklabnik steveklabnik deleted the doc_iter_traits branch June 19, 2016 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants