Remove #[derive(Show)] #29148
Merged
Remove #[derive(Show)] #29148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Starting a crater run |
|
Crater reports one regression currently. At least good to know that it's not widespread! Given the low amount of breakage and the fact that warnings have been in place for quite some time I'm going to r+, thanks @petrochenkov! |
alexcrichton
added
the
relnotes
|
⌛ Testing commit 025cf75 with merge 93ab95e... |
|
💔 Test failed - auto-linux-64-nopt-t |
|
The failure looks spurious. |
oli-obk
added a commit
to oli-obk/rust-ids-container
that referenced
this pull request
Oct 20, 2015
`derive(Show)` has been deprecated for a while. This is the only regression detected by crater. See also [the pull request that will break this crate](rust-lang/rust#29148 (comment))
|
@bors: retry On Tue, Oct 20, 2015 at 4:12 AM, Vadim Petrochenkov <
|
|
⌛ Testing commit 025cf75 with merge 5f90a0a... |
|
@bors: retry force |
bors
added a commit
that referenced
this pull request
Oct 20, 2015
Closes #29145 [breaking-change], needs a crater run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29145
[breaking-change], needs a crater run.