Reword curl | sh disclaimer in TRPL §2.1
#29170
Conversation
The paragraph here seemed confusing, so I reworded it. Also added another possible reason why `curl | sh` might be objectionable to users.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/doc/trpl/installing-rust.md
Outdated
There was a problem hiding this comment.
can this be an em dash instead of two hyphens please?
There was a problem hiding this comment.
Sure. Do you want that as an HTML entity or a literal unicode character?
There was a problem hiding this comment.
Either is fine, I guess literal unicode, so it looks nice elsewhere
|
@bors: r+ rollup |
|
📌 Commit 968d17a has been approved by |
|
Sorry about the delay @kini ! Github doesn't give a notification when you push new commits, so I didn't see till now :/ |
…bnik The paragraph here seemed confusing, so I reworded it. Also added another possible reason why `curl | sh` might be objectionable to users. r? @steveklabnik
|
Ah, no problem. That's good to know. From now on I'll leave a comment after pushing new commits. I actually did leave a comment on the thread we had going on the outdated diff, but maybe that didn't send a notification because the diff was outdated. |
|
Ah! I think I probably just missed that one, then :( |
|
Don't worry about it :) Thanks for reviewing! I assume @bors will close this PR automatically once it's merged? |
|
yup!
|
|
⌛ Testing commit 968d17a with merge 83cf3ce... |
The paragraph here seemed confusing, so I reworded it. Also added another possible reason why `curl | sh` might be objectionable to users. r? @steveklabnik
…bnik The paragraph here seemed confusing, so I reworded it. Also added another possible reason why `curl | sh` might be objectionable to users. r? @steveklabnik
4 participants
The paragraph here seemed confusing, so I reworded it. Also added
another possible reason why
curl | shmight be objectionable to users.r? @steveklabnik