Rollup of 5 pull requests #29178
Closed
Rollup of 5 pull requests #29178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Oct 20, 2015
steveklabnik
commented
- Successful merges: Add a regression test for #29122 (fixed in #29134) #29151, Add missing #[test] attribute to test #29158, Fix minor syntax error in Rustonomicon Rc example. #29162, fix markdown in nomicon/dropck #29175, Point core::ptr::Shared to tracking issue #27730. #29176
- Failed merges:
On OS X the linker doesn't like producing a dylib with undefined symbols.
…ichton I suspect this won't work on Windows, but let's be optimistic and try it before disabling.
This test was mysteriously messed with as part of rust-lang#28500 r? @alexcrichton
Yay, markdown isn't standardized and rustbook's parser has subtle incompatibilities with Github's! So in the Github preview you don't see that this list fails to separate from the previous paragraph. I think this should fix it, but I didn't check.
|
@bors: r+ p=1 |
|
📌 Commit 3edb6de has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 3edb6de with merge 0bbc5a3... |
|
💔 Test failed - auto-win-msvc-64-opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.