Build compiler-rt/builtins with MSVC #29233
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
cc: @retep998 |
|
|
||
| # If the clang isn't already enabled, check for GCC, and if it is missing, turn | ||
| # on clang as a backup. | ||
| if [ -z "$CFG_ENABLE_CLANG" -a -z "$CFG_MSVC_ROOT"] |
There was a problem hiding this comment.
This line was changed.
|
This'll need to update the compiler-rt submodule to land I think, and I've pushed https://github.com/rust-lang/compiler-rt/tree/rust-2015-10-23 which should have the most recent tip (which I think has the various patches of ours merged?) |
| @@ -856,230 +856,6 @@ then | |||
| putvar CFG_LOCAL_RUST_ROOT | |||
| fi | |||
|
|
|||
| # Force bitrig to build with clang; gcc doesn't like us there | |||
There was a problem hiding this comment.
In the future, it's useful for large code movement like this to be split out into a separate commit so the changes to it can be reviewed separately, but it's fine for now
There was a problem hiding this comment.
Although actually, could we avoid all this movement for now? I think the logic here is actually that if any triple is not MSVC then we need to look for gcc, but this looks like the logic is that if any triple is MSVC then we don't require gcc
|
Whoops. Didn't see your comments. Hold on. |
|
OK, I've omitted all the skip-GCC/Clang-if-MSVC changes for now. I'd like to keep the ability to build using a prebuilt LLVM though. Also, the Anyway, the MSVC build hasn't been enabled upstream yet; the last change needed is this line. |
|
⌛ Testing commit f4ed46e with merge 4078d02... |
|
💔 Test failed - auto-linux-32-opt |
|
Sigh, I wonder what changed that the autotools build with GCC breaks. @alexcrichton I'll fix this tomorrow. I expect it's just |
|
I hope chomping I don't even know why GCC is complaining. I checked the builtin's signature in It should work now. |
|
@bors: r+ 12150e3f1077865e56694d92ff0f0b735a2e134b |
|
⌛ Testing commit 12150e3 with merge 905bb4c... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
OK, I've fixed the regressions on FreeBSD and Android. |
|
@bors: r+ c31537e9ac0f1f365686771553276cbf46ebc1e1 |
|
⌛ Testing commit c31537e with merge 8592f17... |
|
I'd like to point out travis indicates this PR broke make tidy. |
|
💔 Test failed - auto-linux-cross-opt |
The build broke because my commits to compiler-rt had not been merged yet. Git was unable to checkout a nonexistent refspec. |
|
Fixed regressions on AArch64, MIPS and MIPSEL. Couldn't find a binary cross-compiler for MIPS unfortunately. I'll look into building our own one day.. sigh. I disabled |
|
🙀 |
Build compiler-rt/builtins with MSVC. r? @alexcrichton
Build compiler-rt/builtins with MSVC.
r? @alexcrichton