Workaround for #28871 #29241
Workaround for #28871 #29241
Conversation
trait definitions, and give prefence to the former. This is consistent with what we do for selection. It also works around a limitation that was leading to rust-lang#28871.
brson
added
the
beta-nominated
|
@rust-lang/lang nominating this for backport to beta. I'd like to do so tomorrow. |
|
Presuming we opt to land it, I'm ok w/ backporting this; it's a very minor patch, fixes a regression. (That was, indeed, the point.) |
|
I would prefer to normalize the projection's trait-ref (so they will deduplicate), but I guess this makes sense too. |
|
r+ modulo the test working. |
In general I prefer that as well. I didn't have much time yesterday so I On Fri, Oct 23, 2015 at 9:20 AM, arielb1 notifications@github.com wrote:
|
|
@bors r+ |
|
📌 Commit b69e08c has been approved by |
nikomatsakis
added
the
beta-accepted
|
Given the time frame, I'm going to declare this beta-accepted, as I don't anticipate any objections from @rust-lang/lang members. Let me know if I am mistaken. |
brson
removed
the
beta-nominated
Give preference to projections from where-clauses over those from trait definitions. This makes #28871 work again, though I think there's more to fix in this general area.
r? @arielb1
cc @brson (fixes regression)