-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Stabilize library APIs for 1.5 #29254
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
r? @brson |
cc @rust-lang/libs, would be good to get lots of eyes on this |
@bors r+ |
📌 Commit a84f62b has been approved by |
⌛ Testing commit a84f62b with merge 604a69f... |
💔 Test failed - auto-mac-64-opt |
a84f62b
to
99c0eaa
Compare
@bors: r=brson 99c0eaab10b753afd0beee9c518cfd2ec1594ddd |
⌛ Testing commit 99c0eaa with merge abf7a85... |
💔 Test failed - auto-mac-64-opt |
99c0eaa
to
68162b4
Compare
@bors: r=brson 68162b4 |
⌛ Testing commit 68162b4 with merge c9c0627... |
💔 Test failed - auto-mac-64-opt |
68162b4
to
8cab27e
Compare
@bors: r=brson 8cab27e |
⌛ Testing commit 8cab27e with merge 23b37e4... |
💔 Test failed - auto-linux-64-nopt-t |
This commit stabilizes and deprecates library APIs whose FCP has closed in the last cycle, specifically: Stabilized APIs: * `fs::canonicalize` * `Path::{metadata, symlink_metadata, canonicalize, read_link, read_dir, exists, is_file, is_dir}` - all moved to inherent methods from the `PathExt` trait. * `Formatter::fill` * `Formatter::width` * `Formatter::precision` * `Formatter::sign_plus` * `Formatter::sign_minus` * `Formatter::alternate` * `Formatter::sign_aware_zero_pad` * `string::ParseError` * `Utf8Error::valid_up_to` * `Iterator::{cmp, partial_cmp, eq, ne, lt, le, gt, ge}` * `<[T]>::split_{first,last}{,_mut}` * `Condvar::wait_timeout` - note that `wait_timeout_ms` is not yet deprecated but will be once 1.5 is released. * `str::{R,}MatchIndices` * `str::{r,}match_indices` * `char::from_u32_unchecked` * `VecDeque::insert` * `VecDeque::shrink_to_fit` * `VecDeque::as_slices` * `VecDeque::as_mut_slices` * `VecDeque::swap_remove_front` - (renamed from `swap_front_remove`) * `VecDeque::swap_remove_back` - (renamed from `swap_back_remove`) * `Vec::resize` * `str::slice_mut_unchecked` * `FileTypeExt` * `FileTypeExt::{is_block_device, is_char_device, is_fifo, is_socket}` * `BinaryHeap::from` - `from_vec` deprecated in favor of this * `BinaryHeap::into_vec` - plus a `Into` impl * `BinaryHeap::into_sorted_vec` Deprecated APIs * `slice::ref_slice` * `slice::mut_ref_slice` * `iter::{range_inclusive, RangeInclusive}` * `std::dynamic_lib` Closes rust-lang#27706 Closes rust-lang#27725 cc rust-lang#27726 (align not stabilized yet) Closes rust-lang#27734 Closes rust-lang#27737 Closes rust-lang#27742 Closes rust-lang#27743 Closes rust-lang#27772 Closes rust-lang#27774 Closes rust-lang#27777 Closes rust-lang#27781 cc rust-lang#27788 (a few remaining methods though) Closes rust-lang#27790 Closes rust-lang#27793 Closes rust-lang#27796 Closes rust-lang#27810 cc rust-lang#28147 (not all parts stabilized)
8cab27e
to
ff49733
Compare
This commit stabilizes and deprecates library APIs whose FCP has closed in the last cycle, specifically: Stabilized APIs: * `fs::canonicalize` * `Path::{metadata, symlink_metadata, canonicalize, read_link, read_dir, exists, is_file, is_dir}` - all moved to inherent methods from the `PathExt` trait. * `Formatter::fill` * `Formatter::width` * `Formatter::precision` * `Formatter::sign_plus` * `Formatter::sign_minus` * `Formatter::alternate` * `Formatter::sign_aware_zero_pad` * `string::ParseError` * `Utf8Error::valid_up_to` * `Iterator::{cmp, partial_cmp, eq, ne, lt, le, gt, ge}` * `<[T]>::split_{first,last}{,_mut}` * `Condvar::wait_timeout` - note that `wait_timeout_ms` is not yet deprecated but will be once 1.5 is released. * `str::{R,}MatchIndices` * `str::{r,}match_indices` * `char::from_u32_unchecked` * `VecDeque::insert` * `VecDeque::shrink_to_fit` * `VecDeque::as_slices` * `VecDeque::as_mut_slices` * `VecDeque::swap_remove_front` - (renamed from `swap_front_remove`) * `VecDeque::swap_remove_back` - (renamed from `swap_back_remove`) * `Vec::resize` * `str::slice_mut_unchecked` * `FileTypeExt` * `FileTypeExt::{is_block_device, is_char_device, is_fifo, is_socket}` * `BinaryHeap::from` - `from_vec` deprecated in favor of this * `BinaryHeap::into_vec` - plus a `Into` impl * `BinaryHeap::into_sorted_vec` Deprecated APIs * `slice::ref_slice` * `slice::mut_ref_slice` * `iter::{range_inclusive, RangeInclusive}` * `std::dynamic_lib` Closes #27706 Closes #27725 cc #27726 (align not stabilized yet) Closes #27734 Closes #27737 Closes #27742 Closes #27743 Closes #27772 Closes #27774 Closes #27777 Closes #27781 cc #27788 (a few remaining methods though) Closes #27790 Closes #27793 Closes #27796 Closes #27810 cc #28147 (not all parts stabilized)
This commit stabilizes and deprecates library APIs whose FCP has closed in the
last cycle, specifically:
Stabilized APIs:
fs::canonicalize
Path::{metadata, symlink_metadata, canonicalize, read_link, read_dir, exists, is_file, is_dir}
- all moved to inherent methods from thePathExt
trait.Formatter::fill
Formatter::width
Formatter::precision
Formatter::sign_plus
Formatter::sign_minus
Formatter::alternate
Formatter::sign_aware_zero_pad
string::ParseError
Utf8Error::valid_up_to
Iterator::{cmp, partial_cmp, eq, ne, lt, le, gt, ge}
<[T]>::split_{first,last}{,_mut}
Condvar::wait_timeout
- note thatwait_timeout_ms
is not yet deprecatedbut will be once 1.5 is released.
str::{R,}MatchIndices
str::{r,}match_indices
char::from_u32_unchecked
VecDeque::insert
VecDeque::shrink_to_fit
VecDeque::as_slices
VecDeque::as_mut_slices
VecDeque::swap_remove_front
- (renamed fromswap_front_remove
)VecDeque::swap_remove_back
- (renamed fromswap_back_remove
)Vec::resize
str::slice_mut_unchecked
FileTypeExt
FileTypeExt::{is_block_device, is_char_device, is_fifo, is_socket}
BinaryHeap::from
-from_vec
deprecated in favor of thisBinaryHeap::into_vec
- plus aInto
implBinaryHeap::into_sorted_vec
Deprecated APIs
slice::ref_slice
slice::mut_ref_slice
iter::{range_inclusive, RangeInclusive}
std::dynamic_lib
Closes #27706
Closes #27725
cc #27726 (align not stabilized yet)
Closes #27734
Closes #27737
Closes #27742
Closes #27743
Closes #27772
Closes #27774
Closes #27777
Closes #27781
cc #27788 (a few remaining methods though)
Closes #27790
Closes #27793
Closes #27796
Closes #27810
cc #28147 (not all parts stabilized)