Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object_safety: check whether a supertrait contains Self even without … #29259

Merged
merged 1 commit into from
Oct 24, 2015
Merged

object_safety: check whether a supertrait contains Self even without … #29259

merged 1 commit into from
Oct 24, 2015

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Oct 23, 2015

…being it

This is a [breaking-change]:lang, but the broken code does not make
much sense.

Fixes #26056

r? @eddyb

@arielb1
object_safety: check whether a supertrait contains Self even without …
5d6d26c 
…being it

This is a [breaking-change]:lang, but the broken code does not make
much sense.

Fixes rust-lang#26056
@eddyb
Copy link
Member

eddyb commented Oct 24, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Oct 24, 2015

📌 Commit 5d6d26c has been approved by eddyb

@bors
Copy link
Contributor

bors commented Oct 24, 2015

⌛ Testing commit 5d6d26c with merge faa35a3...

@bors
Copy link
Contributor

bors commented Oct 24, 2015

💔 Test failed - auto-linux-64-opt

@arielb1
Copy link
Contributor Author

arielb1 commented Oct 24, 2015

@bors retry

bors added a commit that referenced this pull request Oct 24, 2015
@bors
Auto merge of #29259 - arielb1:supertrait-self-2, r=eddyb
04e497c 
…being it

This is a [breaking-change]:lang, but the broken code does not make
much sense.

Fixes #26056

r? @eddyb
@bors
Copy link
Contributor

bors commented Oct 24, 2015

⌛ Testing commit 5d6d26c with merge 04e497c...

@bors
Copy link
Contributor

bors commented Oct 24, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 5d6d26c into rust-lang:master Oct 24, 2015
@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arielb1 @eddyb @bors @brson