Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #26886 #29273

Merged
merged 1 commit into from
Oct 25, 2015
Merged

Add regression test for #26886 #29273

merged 1 commit into from
Oct 25, 2015

Conversation

Manishearth
Copy link
Member

No description provided.

@Manishearth Manishearth mentioned this pull request Oct 24, 2015
Closed
@tbu-
Copy link
Contributor

tbu- commented Oct 24, 2015

Could you modify that to include this?

std::sync::{self, Arc};
std::sync::Arc;
std::sync;

The self thing is what originally triggered the bug.

@Manishearth
Copy link
Member Author

Done

@tbu-
Copy link
Contributor

tbu- commented Oct 24, 2015

Thanks!

@apasel422
Copy link
Contributor

I assume the commit message for this should include Closes #26886?

@Manishearth
Copy link
Member Author

Doesn't need to, but adding.

@alexcrichton
Copy link
Member

@bors: r+ aec5576

@bors
Copy link
Collaborator

bors commented Oct 25, 2015

⌛ Testing commit aec5576 with merge f68cd9a...

bors added a commit that referenced this pull request Oct 25, 2015
@bors
Auto merge of #29273 - Manishearth:regression, r=alexcrichton
f68cd9a 
None
@bors
Copy link
Collaborator

bors commented Oct 25, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit aec5576 into rust-lang:master Oct 25, 2015
@Manishearth Manishearth deleted the regression branch December 2, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Manishearth @tbu- @apasel422 @alexcrichton @bors