Revert "Remove unnecessary trait accessibility check." #29325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn main() { | ||
| <i32 as ::foo::Bar>::baz(); //~ERROR method `baz` is inaccessible | ||
| //~^NOTE: trait `Bar` is private | ||
| } |
There was a problem hiding this comment.
Do we need to remove this test - it should still fail, right?
There was a problem hiding this comment.
Oh true, this was just lumped in the git revert commands, but I'll throw it in regardless
|
r+ with or without test |
alexcrichton
force-pushed
the
revert-trait-accessibility
branch
from
3aac5df
to
31fa916
Compare
bors
added a commit
that referenced
this pull request
Oct 27, 2015
These commits revert #28504 and add a regression test pointed out by @petrochenkov, it's not immediately clear with the regression that the accessibility check should be removed, so for now preserve the behavior on stable by default. r? @nrc
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits revert #28504 and add a regression test pointed out by @petrochenkov, it's not immediately clear with the regression that the accessibility check should be removed, so for now preserve the behavior on stable by default.
r? @nrc