rustfmt for libgraphviz #29414
rustfmt for libgraphviz #29414
Conversation
Run rustfmt on libgraphviz Tested: make -j8 check-stage1-std Also ran rustfmt a second time to verify the transformation was stable.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @nrc Not sure about the raw strings around line 1037 in the lhs -- do you have advice for that? |
| @@ -63,7 +63,8 @@ | |||
| //! } | |||
| //! | |||
| //! impl<'a> dot::Labeller<'a, Nd, Ed> for Edges { | |||
| //! fn graph_id(&'a self) -> dot::Id<'a> { dot::Id::new("example1").unwrap() } | |||
| //! fn graph_id(&'a self) -> dot::Id<'a> { | |||
There was a problem hiding this comment.
this doesn't look right either
There was a problem hiding this comment.
|
@stevencanfield thanks for the PR and sorry it took me a while to get to it (I've been travelling). There's a couple of good fixes here that I'd like to take, but the formatting of code in doc comments is a known problem with rustfmt and I think we should not land them. The raw string changes are interesting - I'm not sure if they are an improvement or not - do you have an opinion? I filed a rustfmt issue in any case. I was thinking that since the lines after the first are not indented, nor should the first be, but it is indented by the |
|
☔ The latest upstream changes (presumably #30017) made this pull request unmergeable. Please resolve the merge conflicts. |
|
sorry for my radio silence here. I'm fine with indenting the "first line" in a raw string (where if I understand correctly, the first line is the one that has the actual (I suppose I'd probably opt for whatever the current emacs-mode does, which is probably a terrible way to make decisions. :) ) |
|
@nrc is |
|
@pnkfelix sounds good. @stevencanfield sorry this PR got lost in review churn and thanks for contributing it. It needs a rebase, but I think some of these changes have landed in the meantime. So closing this PR. |
Run rustfmt on libgraphviz
Tested: make -j8 check-stage1-std
Also ran rustfmt a second time to verify the transformation was stable.