Skip to content

Specify Microsoft Windows and Mac OS X explicitly #29528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2015
Merged

Specify Microsoft Windows and Mac OS X explicitly #29528

merged 1 commit into from
Nov 4, 2015

Conversation

amitsaha
Copy link
Contributor

@amitsaha amitsaha commented Nov 2, 2015

When referring to the different shared library extensions, specify the OS explicitly.

When referring to the different shared library extensions, specify the OS explicitly.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 3, 2015

📌 Commit 900f36f has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

Thanks @amitsaha !

@bors
Copy link
Collaborator

bors commented Nov 3, 2015

⌛ Testing commit 900f36f with merge 358b321...

@bors
Copy link
Collaborator

bors commented Nov 3, 2015

💔 Test failed - auto-mac-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Nov 3, 2015 at 11:29 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/6999


Reply to this email directly or view it on GitHub
#29528 (comment).

@amitsaha
Copy link
Contributor Author

amitsaha commented Nov 3, 2015

Thanks for considering this as an improvement!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 4, 2015
…s-minor, r=nikomatsakis

When referring to the different shared library extensions, specify the OS explicitly.
@bors
Copy link
Collaborator

bors commented Nov 4, 2015

⌛ Testing commit 900f36f with merge 14db074...

bors added a commit that referenced this pull request Nov 4, 2015
…nikomatsakis

When referring to the different shared library extensions, specify the OS explicitly.
@bors bors merged commit 900f36f into rust-lang:master Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants