-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix #29533 #29535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #29533 #29535
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
So, this is good, but why not just |
Sure, avoiding unwinding doesn't seem necessary here, so I'll change this to |
@steveklabnik should be okay now |
@bors: r+ rollup |
📌 Commit d9df16b has been approved by |
This basically just inlines the fatal! macro from BurntSushi's [blog post](http://blog.burntsushi.net/rust-error-handling/#argument-parsing). cc @steveklabnik
Great! Thanks so much :) |
No problem :-) |
This basically just inlines the fatal! macro from BurntSushi's blog post.
cc @steveklabnik