target_family configuration #29551
target_family configuration #29551
Conversation
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
This looks good to me. Do you have any specific value in mind? |
| ]; | ||
| match &fam[..] { | ||
| "windows" | "unix" => ret.push(attr::mk_word_item(fam), |
There was a problem hiding this comment.
As can be seen from Travis, there is an unclosed paren here.
There was a problem hiding this comment.
Ugh, somehow grabbed the wrong commit, will fix...
|
So, the most important value is actually "not unix or windows". For unique one-off platforms that don't really share implementation details with others, it's probably best to set it to If I had my way I'd get rid of it entirely and replace it with specific things like |
|
⌛ Testing commit efdf9aa with merge 8f7da9a... |
|
💔 Test failed - auto-win-gnu-32-opt |
|
@bors: retry On Fri, Nov 6, 2015 at 1:11 PM, bors notifications@github.com wrote:
|
Allow the changing of `target_family` through flexible configuration. The whole computing world isn't just a binary of *nix and Windows! Makes porting `libstd` and co to new platforms a lot less painful.
Allow the changing of
target_familythrough flexible configuration. The whole computing world isn't just a binary of *nix and Windows! Makes portinglibstdand co to new platforms a lot less painful.