-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Tt
prefix from TokenType variants
#29582
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Can you add |
done |
@bors r+ |
📌 Commit 5f97df7 has been approved by |
⌛ Testing commit 5f97df7 with merge be6028c... |
💔 Test failed - auto-mac-64-nopt-t |
Looks like there are some tests that need to be modified as well. |
[breaking change]
sorry about that... grep now returns no results for |
@bors r+ |
📌 Commit fcc7067 has been approved by |
rust-lang/rust#29582 renamed `TtToken` to `Token`. rust-lang/rust#29285 renamed `parse_expr` to `parse_expr_panic`.
[breaking change] I'm not sure if those renames are ok. [TokenType::Tt* to TokenType::*](#29582) was obvious, but for all those Item-enums it's less obvious to me what the right way forward is due to the underscore.
[breaking change] I'm not sure if those renames are ok. [TokenType::Tt* to TokenType::*](rust-lang/rust#29582) was obvious, but for all those Item-enums it's less obvious to me what the right way forward is due to the underscore.
No description provided.