Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Tt prefix from TokenType variants #29582

Merged
merged 1 commit into from
Nov 6, 2015
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 4, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sfackler
Copy link
Member

sfackler commented Nov 4, 2015

Can you add [breaking change] to the commit message? LGTM otherwise.

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 5, 2015

done

@sfackler
Copy link
Member

sfackler commented Nov 5, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Nov 5, 2015

📌 Commit 5f97df7 has been approved by sfackler

@bors
Copy link
Contributor

bors commented Nov 5, 2015

⌛ Testing commit 5f97df7 with merge be6028c...

@bors
Copy link
Contributor

bors commented Nov 5, 2015

💔 Test failed - auto-mac-64-nopt-t

@sfackler
Copy link
Member

sfackler commented Nov 5, 2015

Looks like there are some tests that need to be modified as well.

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 6, 2015

sorry about that... grep now returns no results for TtToken, TtDelim or TtSeqence

@sfackler
Copy link
Member

sfackler commented Nov 6, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Nov 6, 2015

📌 Commit fcc7067 has been approved by sfackler

@bors
Copy link
Contributor

bors commented Nov 6, 2015

⌛ Testing commit fcc7067 with merge 475f91f...

bors added a commit that referenced this pull request Nov 6, 2015
@bors bors merged commit fcc7067 into rust-lang:master Nov 6, 2015
dgrunwald added a commit to dgrunwald/interpolate_idents that referenced this pull request Nov 7, 2015
rust-lang/rust#29582 renamed `TtToken` to `Token`.
rust-lang/rust#29285 renamed `parse_expr` to `parse_expr_panic`.
bors added a commit that referenced this pull request Nov 17, 2015
[breaking change]

I'm not sure if those renames are ok. [TokenType::Tt* to TokenType::*](#29582) was obvious, but for all those Item-enums it's less obvious to me what the right way forward is due to the underscore.
@oli-obk oli-obk deleted the token_tree branch November 20, 2015 13:48
critiqjo pushed a commit to critiqjo/rustdoc that referenced this pull request Dec 16, 2016
[breaking change]

I'm not sure if those renames are ok. [TokenType::Tt* to TokenType::*](rust-lang/rust#29582) was obvious, but for all those Item-enums it's less obvious to me what the right way forward is due to the underscore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants