Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs for Reflect: blank line after first sentence #29593

Merged
merged 1 commit into from
Nov 5, 2015

Conversation

ben0x539
Copy link
Contributor

@ben0x539 ben0x539 commented Nov 4, 2015

Rustdoc takes the first paragraph as a summary, so having a huge
paragraph that ends with introducing an example looked somewhat wrong on
the module page.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 4, 2015

📌 Commit d7a3260 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 5, 2015
…veklabnik

Rustdoc takes the first paragraph as a summary, so having a huge
paragraph that ends with introducing an example looked somewhat wrong on
the module page.
@steveklabnik
Copy link
Member

This failed the rollup because there's trailing whitespace, can you make sure to trim it, please?

@steveklabnik
Copy link
Member

@bors: r-

Rustdoc takes the first paragraph as a summary, so having a huge
paragraph that ends with introducing an example looked somewhat wrong on
the module page.
@ben0x539 ben0x539 force-pushed the reflect-doc-comment branch from d7a3260 to 4db95e6 Compare November 5, 2015 12:39
@ben0x539
Copy link
Contributor Author

ben0x539 commented Nov 5, 2015

Whoops. Updated with "/// " -> "///".

r? @steveklabnik

@steveklabnik
Copy link
Member

@bors: r+ rollup

no worries, I do that all the time

@bors
Copy link
Collaborator

bors commented Nov 5, 2015

📌 Commit 4db95e6 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Nov 5, 2015

⌛ Testing commit 4db95e6 with merge 74185af...

bors added a commit that referenced this pull request Nov 5, 2015
Rustdoc takes the first paragraph as a summary, so having a huge
paragraph that ends with introducing an example looked somewhat wrong on
the module page.
@bors bors merged commit 4db95e6 into rust-lang:master Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants