rustc_privacy: Do not export items needed solely for the reachability analysis #29620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… analysis Process them in middle::reachable instead Add tests for reachability of trait methods written in UFCS form
| self.exported_items.insert(item.id); | ||
| if exported_ty && exported_trait { | ||
| self.exported_items.insert(item.id); | ||
| } |
There was a problem hiding this comment.
This pattern comes up quite a bit in this module of:
if public {
self.public_items.insert(id);
}
if exported {
self.exported_items.insert(id);
}Perhaps that could be a helper/macro? Not sure if it'd help readability, but figured I'd throw out the idea!
bors
added a commit
that referenced
this pull request
Nov 6, 2015
Handle them in `middle::reachable` instead (no optimizations so far, just drop all trait impl items into the reachable set, as before). Addresses the concerns from #29291 (comment) \+ In `middle::reachable` don't treat impls of `Drop` specially, they are subsumed by the general impl treatment. \+ Add some tests checking reachability of trait methods written in UFCS form \+ Minor refactoring in the second commit r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle them in
middle::reachableinstead (no optimizations so far, just drop all trait impl items into the reachable set, as before). Addresses the concerns from #29291 (comment)middle::reachabledon't treat impls ofDropspecially, they are subsumed by the general impl treatment.r? @alexcrichton