sleep_ms -> sleep #29622
Merged
sleep_ms -> sleep #29622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ |
|
📌 Commit 500e8db has been approved by |
| @@ -131,7 +132,7 @@ fn main() { | |||
| }); | |||
| } | |||
|
|
|||
| thread::sleep_ms(50); | |||
| thread::sleep(Duration::from_millis(50); | |||
There was a problem hiding this comment.
Needs another close paren.
There was a problem hiding this comment.
figures, with the ignore I didn't see it :/
|
@bors: r- pending a fix to @aravind-pg's comment. |
| @@ -614,8 +617,8 @@ We have three new lines. We’ve added an argument, `table`. We access the | |||
| the fork at that particular index. That gives us access to the `Mutex` at that | |||
| index, and we call `lock()` on it. If the mutex is currently being accessed by | |||
| someone else, we’ll block until it becomes available. We have also a call to | |||
| `thread::sleep_ms` between the moment first fork is picked and the moment the | |||
| second forked is picked, as the process of picking up the fork is not | |||
| `thread::sleep` between the moment first fork is picked and the moment the | |||
There was a problem hiding this comment.
s/moment first/moment the first/
|
@bors: r=bstrie rollup |
|
📌 Commit 801f83f has been approved by |
Now that thread::sleep is a real thing, let's use it Fixes rust-lang#29621
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 7, 2015
Now that thread::sleep is a real thing, let's use it Fixes rust-lang#29621 r? @bstrie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that thread::sleep is a real thing, let's use it
Fixes #29621
r? @bstrie