-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goyox86/rustfmting librustc front II #29647
Goyox86/rustfmting librustc front II #29647
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
r? @nrc |
PatRegion(ref inner, mutbl) => hir::PatRegion(lower_pat(_lctx, inner), | ||
lower_mutability(_lctx, mutbl)), | ||
PatRegion(ref inner, mutbl) => | ||
hir::PatRegion(lower_pat(_lctx, inner), lower_mutability(_lctx, mutbl)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be braced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for re-doing this - just a couple of things I would fixup (one looks like a bug in rustfmt, but Ok to manually fix it up for now). |
Hey @nrc which are the fixups that are needed? |
@goyox86 Adding braces in lowering.rs, and changing a comment to using |
Fixups done @nrc |
Awesome, thanks! @bors: r+ |
📌 Commit d1b5d9c has been approved by |
⌛ Testing commit d1b5d9c with merge f3b57a3... |
💔 Test failed - auto-mac-64-opt |
d1b5d9c
to
fa99261
Compare
fa99261
to
cbd2ef8
Compare
@bors: r+ |
📌 Commit cbd2ef8 has been approved by |
@bors: retry force On Monday, November 9, 2015, bors notifications@github.com wrote:
|
⚡ Previous build results for auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt... |
@bors: retry force |
Hi Rustaceans!
This is the second take on running latest rustfmt on librustc_front!
This is the same in #29075 but cleaned. All fixups have been applied.
//cc @nrc