Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goyox86/rustfmting librustc front II #29647

Merged
merged 1 commit into from
Nov 10, 2015

Conversation

goyox86
Copy link
Contributor

@goyox86 goyox86 commented Nov 5, 2015

Hi Rustaceans!

This is the second take on running latest rustfmt on librustc_front!

This is the same in #29075 but cleaned. All fixups have been applied.

//cc @nrc

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@goyox86 goyox86 changed the title Goyox86/rustfmting librustc front ii Goyox86/rustfmting librustc front II Nov 5, 2015
@nrc
Copy link
Member

nrc commented Nov 7, 2015

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned pnkfelix Nov 7, 2015
PatRegion(ref inner, mutbl) => hir::PatRegion(lower_pat(_lctx, inner),
lower_mutability(_lctx, mutbl)),
PatRegion(ref inner, mutbl) =>
hir::PatRegion(lower_pat(_lctx, inner), lower_mutability(_lctx, mutbl)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be braced

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrc
Copy link
Member

nrc commented Nov 8, 2015

Thanks for re-doing this - just a couple of things I would fixup (one looks like a bug in rustfmt, but Ok to manually fix it up for now).

@goyox86
Copy link
Contributor Author

goyox86 commented Nov 8, 2015

Hey @nrc which are the fixups that are needed?

@nrc
Copy link
Member

nrc commented Nov 9, 2015

@goyox86 Adding braces in lowering.rs, and changing a comment to using // in hir.rs (there are comments inline).

@goyox86
Copy link
Contributor Author

goyox86 commented Nov 9, 2015

Fixups done @nrc

@nrc
Copy link
Member

nrc commented Nov 9, 2015

Awesome, thanks!

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

📌 Commit d1b5d9c has been approved by nrc

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

⌛ Testing commit d1b5d9c with merge f3b57a3...

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

💔 Test failed - auto-mac-64-opt

@goyox86 goyox86 force-pushed the goyox86/rustfmting-librustc_frontII branch from d1b5d9c to fa99261 Compare November 9, 2015 21:55
@goyox86 goyox86 force-pushed the goyox86/rustfmting-librustc_frontII branch from fa99261 to cbd2ef8 Compare November 9, 2015 21:56
@nrc
Copy link
Member

nrc commented Nov 9, 2015

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

📌 Commit cbd2ef8 has been approved by nrc

bors added a commit that referenced this pull request Nov 9, 2015
…=nrc

Hi Rustaceans!

This is the second take  on running latest rustfmt on librustc_front!

This is the same in #29075 but cleaned. All fixups have been applied.

//cc @nrc
@bors
Copy link
Collaborator

bors commented Nov 9, 2015

⌛ Testing commit cbd2ef8 with merge 205406c...

@alexcrichton
Copy link
Member

@bors: retry force

On Monday, November 9, 2015, bors notifications@github.com wrote:

[image: ⌛] Testing commit cbd2ef8
cbd2ef8
with merge 205406c
205406c
...


Reply to this email directly or view it on GitHub
#29647 (comment).

@alexcrichton
Copy link
Member

@bors: retry force

@bors
Copy link
Collaborator

bors commented Nov 10, 2015

⌛ Testing commit cbd2ef8 with merge 4b23a09...

bors added a commit that referenced this pull request Nov 10, 2015
…=nrc

Hi Rustaceans!

This is the second take  on running latest rustfmt on librustc_front!

This is the same in #29075 but cleaned. All fixups have been applied.

//cc @nrc
@bors bors merged commit cbd2ef8 into rust-lang:master Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants