-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hygiene regression in patterns #29748
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
f827585
to
6070c3d
Compare
6070c3d
to
fa3cd51
Compare
Ok, now all tests pass. |
Nominating for backport. Linked issues says this is on beta. cc @rust-lang/compiler |
It looks like there are couple of very similar issues in rustc_trans and rustc_mir, in places where "the first of bindings with the same name" is needed in
|
fa3cd51
to
2504e31
Compare
Updated with fixes for mir and trans. |
☔ The latest upstream changes (presumably #29763) made this pull request unmergeable. Please resolve the merge conflicts. |
r+ with a rebase. I am really unhappy about keeping the mtwt tables around longer than we have to - this will cause memory use and possibly compile time regressions. But I guess it is better to be slow and correct. I'll file an issue for a better fix. |
r? @nrc (since he already reviewed) |
2504e31
to
fba1926
Compare
Rebased. |
@bors: r+ |
📌 Commit fba1926 has been approved by |
⌛ Testing commit fba1926 with merge cc30948... |
Accepted for beta because this is a regression. |
This doesn't cherry-pick cleanly at all. Can somebody else do it in the next week or so? @petrochenkov perhaps? |
Closes #29746