Changes to data produced by privacy pass #29822
Conversation
|
☔ The latest upstream changes (presumably #29766) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
force-pushed
the
pubexport
branch
from
c0bc429
to
c1ad5af
Compare
|
Updated. |
| self.ty_level(&ty) | ||
| } | ||
| hir::ItemImpl(_, _, _, Some(ref trait_ref), ref ty, _) => { | ||
| cmp::min(self.ty_level(&ty), self.trait_level(trait_ref)) |
There was a problem hiding this comment.
This is some pretty slick usage of PartialOrd (and all the instances above)
|
Nice work, thanks @petrochenkov! (sorry for being a little slow to get to a review) Do you think that this'll need a crater run? It looks pretty straigtforward to me, but I'm curious if you ran across anything while working on it. Also just making sure, but you've given the docs a glance to make sure nothing major is missing? (e.g. |
Probably not (though, in a perfect world a crater run on every PR would be nice :)
Yes, I usually use |
This patch implements the plan described in https://internals.rust-lang.org/t/privacy-and-its-interaction-with-docs-lints-and-stability/2880 with one deviation. It turns out, that rustdoc needs the "directly public" set for its docs inlining logic, so the privacy pass have to produce three sets and not two. Three is arguably too many, so I merged them in one map: `public_items/exported_items/reachable_items: NodeSet => access_levels: NodeMap<AccessLevel>` r? @alexcrichton
Fixes #16734 and probably some other issues This is a continuation of #29822, but the algorithm is mostly a copy of #29973, so r? @alexcrichton or @nikomatsakis
This patch implements the plan described in https://internals.rust-lang.org/t/privacy-and-its-interaction-with-docs-lints-and-stability/2880 with one deviation.
It turns out, that rustdoc needs the "directly public" set for its docs inlining logic, so the privacy pass have to produce three sets and not two. Three is arguably too many, so I merged them in one map:
public_items/exported_items/reachable_items: NodeSet => access_levels: NodeMap<AccessLevel>r? @alexcrichton