Fix formatting of multiline code blocks in asm-comments #3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
added a commit
that referenced
this pull request
Jul 23, 2012
Fix formatting of multiline code blocks in asm-comments
|
Merged, thanks! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
Fix typo in usage text
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Oct 6, 2023
auto-detect no_std where possible r? `@oli-obk` Cc https://rust-lang.zulipchat.com/#narrow/stream/269128-miri/topic/restricted_std.20sysroot.3F
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Oct 7, 2023
auto-detect no_std where possible r? `@oli-obk` Cc https://rust-lang.zulipchat.com/#narrow/stream/269128-miri/topic/restricted_std.20sysroot.3F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with -S, the rust source code for each is included as a comment in an InlineAsm block. However, if the code block contains new-lines, the only the first line ends up being correctly commented and indented. This patch updates the comment sanitizing code to deal correctly with newlines.