Rollup of 6 pull requests #30024
Closed
Rollup of 6 pull requests #30024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the file was not regenrated upon modification of src/rustllvm or others. Now it will be rebuilt if `src/llvm` or `src/rustllvm` is touched. Also added *.rs rule to 'clean' rule so that it is removed upon 'make clean'.
It was introduced with the change that made copy opt-in. The implementation gives a warning, because the struct contains a raw pointer.
Previously the file was not regenrated upon modification of `src/rustllvm` or others. Now it will be rebuilt if `src/llvm` or `src/rustllvm` is touched. Also added *.rs rule to 'clean' rule so that it is removed upon 'make clean'. Fixes rust-lang#28614.
…sakis It was introduced with the change that made copy opt-in. The implementation gives a warning, because the struct contains a raw pointer.
…r, r=alexcrichton Good candidate for a rollup, this one.
`unit` was in code formatting, which is wrong, since it's not actual code. The correct code is `()`.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit 0a3b429 has been approved by |
|
⌛ Testing commit 0a3b429 with merge 41d444b... |
|
💔 Test failed - auto-linux-64-nopt-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[derive(Copy)]#29933, Avoid some code duplication around getting names of numeric types. #30004, Fix up docs for char #30013, Clarify reference about main returning unit #30020, Use the EntryOrExit variants qualified. #30023