Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo instructions for dinning_philosophers project #30038

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Nov 24, 2015

At this point of the book, reader have likely use cargo new --bin,
likely 2 times, once if they are lazy. This remind them of the cargo
syntax.

I was myself unsure whether it was cargo create, cargo new, and
whether it would initialize in current working directory or needed a
target.

Otherwise thanks, I've been writing rust for a few hours, and likes it so far.

At this point of the book, reader have likely use `cargo new --bin`,
likely 2 times, once if they are lazy. This remind them of the `cargo`
syntax.

I was myself unsure whether it was `cargo create`, `cargo new`, and
whether it would initialize in current working directory or needed a
target.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks! agree that this is a great addition.

@bors
Copy link
Collaborator

bors commented Nov 24, 2015

📌 Commit 5aa4507 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 25, 2015
…labnik

At this point of the book, reader have likely use `cargo new --bin`,
likely 2 times, once if they are lazy. This remind them of the `cargo`
syntax.

I was myself unsure whether it was `cargo create`, `cargo new`, and
whether it would initialize in current working directory or needed a
target.

--

Otherwise thanks, I've been writing rust for a few hours, and likes it so far.
bors added a commit that referenced this pull request Nov 25, 2015
@bors bors merged commit 5aa4507 into rust-lang:master Nov 25, 2015
@Carreau Carreau deleted the cargo-philosopher branch November 25, 2015 08:22
@Carreau
Copy link
Contributor Author

Carreau commented Nov 25, 2015

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants