Skip to content

Document std::string::ParseError #30120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

steveklabnik
Copy link
Member

Part of #29376

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Perhaps this could explicitly call out that this type will never exist as it is an empty enum?

@steveklabnik
Copy link
Member Author

What specific aspect of "never exist" distinct from "this type should never actually be returned", that it's zero-sized?

@alexcrichton
Copy link
Member

Ah sorry I should think more before commenting! I found it a little odd when reading that the first few clauses were all talking about how this error is returned only to later say "but actually this doesn't happen". Perhaps this could just be rephrased to give the impression initially that this type is never returned? It may just also be too early in the morning as well...

@steveklabnik
Copy link
Member Author

It may just also be too early in the morning as well...

My docs should be clear at any time of day 🌞 😎

@steveklabnik steveklabnik force-pushed the doc_string_parse_error branch from c7c5068 to 23fb974 Compare November 30, 2015 21:20
@steveklabnik
Copy link
Member Author

@alexcrichton try this version of the text out? does that help?

@alexcrichton
Copy link
Member

@bors: r+ 23fb974

Looks good to me!

@steveklabnik
Copy link
Member Author

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 30, 2015
bors added a commit that referenced this pull request Dec 1, 2015
@bors bors merged commit 23fb974 into rust-lang:master Dec 1, 2015
@steveklabnik steveklabnik deleted the doc_string_parse_error branch June 19, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants