-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Document std::string::ParseError #30120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Perhaps this could explicitly call out that this type will never exist as it is an empty |
What specific aspect of "never exist" distinct from "this type should never actually be returned", that it's zero-sized? |
Ah sorry I should think more before commenting! I found it a little odd when reading that the first few clauses were all talking about how this error is returned only to later say "but actually this doesn't happen". Perhaps this could just be rephrased to give the impression initially that this type is never returned? It may just also be too early in the morning as well... |
My docs should be clear at any time of day 🌞 😎 |
c7c5068
to
23fb974
Compare
@alexcrichton try this version of the text out? does that help? |
@bors: rollup |
…, r=alexcrichton Part of rust-lang#29376
Part of #29376