-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Write better module-level and type-level docs for String #30146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two changes were made to bring this example in line with the module-level version, cc #28835
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
src/libcollections/string.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/counterpoint/counterpart/
8ccc806
to
85a896d
Compare
src/libcollections/string.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"elements" -> "bytes" and "size of the buffer in bytes" perhaps.
85a896d
to
492f6fc
Compare
@brson updated to address the issues, other than the UTF-8 stuff. I think that's something that will have to come later. |
@bors r+ |
📌 Commit 492f6fc has been approved by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is… pretty far away from the “these”. It should either be repeated what “these” are or paragraphs should be reorganised.
Part of #29376