Skip to content

Conversation

steveklabnik
Copy link
Contributor

Part of #29376

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two changes were made to bring this example in line with the module-level version, cc #28835

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/counterpoint/counterpart/

@steveklabnik steveklabnik force-pushed the doc_string_intro branch 3 times, most recently from 8ccc806 to 85a896d Compare December 1, 2015 19:20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"elements" -> "bytes" and "size of the buffer in bytes" perhaps.

@steveklabnik
Copy link
Contributor Author

@brson updated to address the issues, other than the UTF-8 stuff. I think that's something that will have to come later.

@brson
Copy link
Contributor

brson commented Dec 2, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 2, 2015

📌 Commit 492f6fc has been approved by brson

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is… pretty far away from the “these”. It should either be repeated what “these” are or paragraphs should be reorganised.

@bors
Copy link
Collaborator

bors commented Dec 2, 2015

⌛ Testing commit 492f6fc with merge 37e337a...

bors added a commit that referenced this pull request Dec 2, 2015
@bors bors merged commit 492f6fc into rust-lang:master Dec 2, 2015
@steveklabnik steveklabnik deleted the doc_string_intro branch June 19, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants