std: Stabilize APIs for the 1.6 release #30187

alexcrichton · 2015-12-03T18:20:53Z

This commit is the standard API stabilization commit for the 1.6 release cycle.
The list of issues and APIs below have all been through their cycle-long FCP and
the libs team decisions are listed below

Stabilized APIs

Read::read_exact
ErrorKind::UnexpectedEof (renamed from UnexpectedEOF)
libcore -- this was a bit of a nuanced stabilization, the crate itself is now
marked as #[stable] and the methods appearing via traits for primitives like
char and str are now also marked as stable. Note that the extension traits
themeselves are marked as unstable as they're imported via the prelude. The
try! macro was also moved from the standard library into libcore to have the
same interface. Otherwise the functions all have copied stability from the
standard library now.
fs::DirBuilder
fs::DirBuilder::new
fs::DirBuilder::recursive
fs::DirBuilder::create
os::unix::fs::DirBuilderExt
os::unix::fs::DirBuilderExt::mode
vec::Drain
vec::Vec::drain
string::Drain
string::String::drain
vec_deque::Drain
vec_deque::VecDeque::drain
collections::hash_map::Drain
collections::hash_map::HashMap::drain
collections::hash_set::Drain
collections::hash_set::HashSet::drain
collections::binary_heap::Drain
collections::binary_heap::BinaryHeap::drain
Vec::extend_from_slice (renamed from push_all)
Mutex::get_mut
Mutex::into_inner
RwLock::get_mut
RwLock::into_inner
Iterator::min_by_key (renamed from min_by)
Iterator::max_by_key (renamed from max_by)

Deprecated APIs

ErrorKind::UnexpectedEOF (renamed to UnexpectedEof)
OsString::from_bytes
OsStr::to_cstring
OsStr::to_bytes
fs::walk_dir and fs::WalkDir
path::Components::peek
slice::bytes::MutableByteVector
slice::bytes::copy_memory
Vec::push_all (renamed to extend_from_slice)
Duration::span
IpAddr
SocketAddr::ip
Read::tee
io::Tee
Write::broadcast
io::Broadcast
Iterator::min_by (renamed to min_by_key)
Iterator::max_by (renamed to max_by_key)
net::lookup_addr

New APIs (still unstable)

<[T]>::sort_by_key (added to mirror min_by_key)

Closes #27585
Closes #27704
Closes #27707
Closes #27710
Closes #27711
Closes #27727
Closes #27740
Closes #27744
Closes #27799
Closes #27801
cc #27801 (doesn't close as Chars is still unstable)
Closes #28968

rust-highfive · 2015-12-03T18:21:06Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-12-03T18:21:06Z

r? @aturon

cc @rust-lang/libs

bors · 2015-12-03T21:30:48Z

☔ The latest upstream changes (presumably #29999) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2015-12-03T22:48:17Z

This commit also notably stabilizes no_std as-is. It didn't seem like there was enough thrust and consensus on #27701 for renaming .

bors · 2015-12-04T05:17:40Z

☔ The latest upstream changes (presumably #30190) made this pull request unmergeable. Please resolve the merge conflicts.

aturon · 2015-12-04T23:03:44Z

src/liballoc/boxed.rs

@@ -527,6 +526,7 @@ impl<I: ExactSizeIterator + ?Sized> ExactSizeIterator for Box<I> {}
 /// ```
 #[rustc_paren_sugar]
 #[unstable(feature = "fnbox", reason = "Newly introduced", issue = "0")]
+#[fundamental]


Just slip that in there :)

This is probably prudent, and technically breaking but it's unstable anyway.

Oh oops, this wasn't supposed to sneak in here

aturon · 2015-12-04T23:09:19Z

This LGTM. We should figure out a story for the libcore docs eventually, but it shouldn't block this PR.

alexcrichton · 2015-12-04T23:22:18Z

@bors: r=aturon ba5bb32

bors · 2015-12-05T02:39:58Z

⌛ Testing commit ba5bb32 with merge b2538d2...

bors · 2015-12-05T02:51:49Z

💔 Test failed - auto-linux-64-opt

alexcrichton · 2015-12-05T18:02:39Z

@bors: r=aturon 8c3ec7be58b38adb5c292ccb5ae386600037b7c1

bors · 2015-12-05T22:44:08Z

⌛ Testing commit 8c3ec7b with merge 70208d4...

bors · 2015-12-05T23:02:02Z

💔 Test failed - auto-win-msvc-32-opt

This commit is the standard API stabilization commit for the 1.6 release cycle. The list of issues and APIs below have all been through their cycle-long FCP and the libs team decisions are listed below Stabilized APIs * `Read::read_exact` * `ErrorKind::UnexpectedEof` (renamed from `UnexpectedEOF`) * libcore -- this was a bit of a nuanced stabilization, the crate itself is now marked as `#[stable]` and the methods appearing via traits for primitives like `char` and `str` are now also marked as stable. Note that the extension traits themeselves are marked as unstable as they're imported via the prelude. The `try!` macro was also moved from the standard library into libcore to have the same interface. Otherwise the functions all have copied stability from the standard library now. * The `#![no_std]` attribute * `fs::DirBuilder` * `fs::DirBuilder::new` * `fs::DirBuilder::recursive` * `fs::DirBuilder::create` * `os::unix::fs::DirBuilderExt` * `os::unix::fs::DirBuilderExt::mode` * `vec::Drain` * `vec::Vec::drain` * `string::Drain` * `string::String::drain` * `vec_deque::Drain` * `vec_deque::VecDeque::drain` * `collections::hash_map::Drain` * `collections::hash_map::HashMap::drain` * `collections::hash_set::Drain` * `collections::hash_set::HashSet::drain` * `collections::binary_heap::Drain` * `collections::binary_heap::BinaryHeap::drain` * `Vec::extend_from_slice` (renamed from `push_all`) * `Mutex::get_mut` * `Mutex::into_inner` * `RwLock::get_mut` * `RwLock::into_inner` * `Iterator::min_by_key` (renamed from `min_by`) * `Iterator::max_by_key` (renamed from `max_by`) Deprecated APIs * `ErrorKind::UnexpectedEOF` (renamed to `UnexpectedEof`) * `OsString::from_bytes` * `OsStr::to_cstring` * `OsStr::to_bytes` * `fs::walk_dir` and `fs::WalkDir` * `path::Components::peek` * `slice::bytes::MutableByteVector` * `slice::bytes::copy_memory` * `Vec::push_all` (renamed to `extend_from_slice`) * `Duration::span` * `IpAddr` * `SocketAddr::ip` * `Read::tee` * `io::Tee` * `Write::broadcast` * `io::Broadcast` * `Iterator::min_by` (renamed to `min_by_key`) * `Iterator::max_by` (renamed to `max_by_key`) * `net::lookup_addr` New APIs (still unstable) * `<[T]>::sort_by_key` (added to mirror `min_by_key`) Closes rust-lang#27585 Closes rust-lang#27704 Closes rust-lang#27707 Closes rust-lang#27710 Closes rust-lang#27711 Closes rust-lang#27727 Closes rust-lang#27740 Closes rust-lang#27744 Closes rust-lang#27799 Closes rust-lang#27801 cc rust-lang#27801 (doesn't close as `Chars` is still unstable) Closes rust-lang#28968

alexcrichton · 2015-12-05T23:09:58Z

@bors: r=aturon 464cdff

bors · 2015-12-06T00:08:49Z

⌛ Testing commit 464cdff with merge f1cd20a...

bors · 2015-12-06T01:40:19Z

💔 Test failed - auto-win-gnu-64-nopt-t

bluss · 2015-12-06T01:42:10Z

@bors retry

bors · 2015-12-06T04:12:55Z

⌛ Testing commit 464cdff with merge c4b1638...

This commit is the standard API stabilization commit for the 1.6 release cycle. The list of issues and APIs below have all been through their cycle-long FCP and the libs team decisions are listed below Stabilized APIs * `Read::read_exact` * `ErrorKind::UnexpectedEof` (renamed from `UnexpectedEOF`) * libcore -- this was a bit of a nuanced stabilization, the crate itself is now marked as `#[stable]` and the methods appearing via traits for primitives like `char` and `str` are now also marked as stable. Note that the extension traits themeselves are marked as unstable as they're imported via the prelude. The `try!` macro was also moved from the standard library into libcore to have the same interface. Otherwise the functions all have copied stability from the standard library now. * `fs::DirBuilder` * `fs::DirBuilder::new` * `fs::DirBuilder::recursive` * `fs::DirBuilder::create` * `os::unix::fs::DirBuilderExt` * `os::unix::fs::DirBuilderExt::mode` * `vec::Drain` * `vec::Vec::drain` * `string::Drain` * `string::String::drain` * `vec_deque::Drain` * `vec_deque::VecDeque::drain` * `collections::hash_map::Drain` * `collections::hash_map::HashMap::drain` * `collections::hash_set::Drain` * `collections::hash_set::HashSet::drain` * `collections::binary_heap::Drain` * `collections::binary_heap::BinaryHeap::drain` * `Vec::extend_from_slice` (renamed from `push_all`) * `Mutex::get_mut` * `Mutex::into_inner` * `RwLock::get_mut` * `RwLock::into_inner` * `Iterator::min_by_key` (renamed from `min_by`) * `Iterator::max_by_key` (renamed from `max_by`) Deprecated APIs * `ErrorKind::UnexpectedEOF` (renamed to `UnexpectedEof`) * `OsString::from_bytes` * `OsStr::to_cstring` * `OsStr::to_bytes` * `fs::walk_dir` and `fs::WalkDir` * `path::Components::peek` * `slice::bytes::MutableByteVector` * `slice::bytes::copy_memory` * `Vec::push_all` (renamed to `extend_from_slice`) * `Duration::span` * `IpAddr` * `SocketAddr::ip` * `Read::tee` * `io::Tee` * `Write::broadcast` * `io::Broadcast` * `Iterator::min_by` (renamed to `min_by_key`) * `Iterator::max_by` (renamed to `max_by_key`) * `net::lookup_addr` New APIs (still unstable) * `<[T]>::sort_by_key` (added to mirror `min_by_key`) Closes #27585 Closes #27704 Closes #27707 Closes #27710 Closes #27711 Closes #27727 Closes #27740 Closes #27744 Closes #27799 Closes #27801 cc #27801 (doesn't close as `Chars` is still unstable) Closes #28968

bors · 2015-12-06T06:49:02Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

rust-highfive assigned brson Dec 3, 2015

rust-highfive assigned aturon and unassigned brson Dec 3, 2015

alexcrichton force-pushed the stabilize-1.6 branch from e73d694 to 93244f8 Compare December 3, 2015 18:27

alexcrichton force-pushed the stabilize-1.6 branch 2 times, most recently from bdf3a1c to 9f2ea07 Compare December 3, 2015 22:47

alexcrichton force-pushed the stabilize-1.6 branch from 9f2ea07 to 42225f7 Compare December 3, 2015 22:55

alexcrichton force-pushed the stabilize-1.6 branch 2 times, most recently from 6daf10b to ee96823 Compare December 4, 2015 19:41

brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Dec 4, 2015

aturon reviewed Dec 4, 2015
View reviewed changes

alexcrichton force-pushed the stabilize-1.6 branch from ee96823 to ba5bb32 Compare December 4, 2015 23:17

alexcrichton mentioned this pull request Dec 4, 2015

Deal with libcore/libstd doc duplication on primitives #30214

Closed

alexcrichton force-pushed the stabilize-1.6 branch from ba5bb32 to 8c3ec7b Compare December 5, 2015 18:02

alexcrichton force-pushed the stabilize-1.6 branch from 8c3ec7b to 464cdff Compare December 5, 2015 23:09

bors merged commit 464cdff into rust-lang:master Dec 6, 2015

This was referenced Dec 6, 2015

libsyntax: be more accepting of whitespace in lexer #29734

Merged

Convert errors in libcore’s try! macro too. #28722

Closed

std: Rename thread::catch_panic to panic::recover #29937

Merged

std: Remove deprecated functionality from 1.5 #30182

Merged

mrmonday mentioned this pull request Dec 6, 2015

NetworkInterface addresses and masks libpnet/libpnet#81

Open

frewsxcv mentioned this pull request Dec 6, 2015

Change host to use ip address types provided by std. servo/rust-url#138

Merged

alexcrichton deleted the stabilize-1.6 branch December 10, 2015 23:40

alexcrichton mentioned this pull request Dec 16, 2015

Tracking issue for libcore + no_std stabilization #27701

Closed

4 tasks

kkawakam mentioned this pull request Dec 20, 2015

Compile against Rust Stable kkawakam/rustyline#17

Closed

5 tasks

phil-opp mentioned this pull request Dec 31, 2015

lib.rs needs #![feature(no_std)] rust-osdev/multiboot2#1

Closed

nagisa mentioned this pull request Aug 10, 2016

rustc claims no_std is stable since 1.0.0 #35579

Closed

ThePuzzlemaker mentioned this pull request Oct 17, 2021

Enhance E0463 "can't find crate" error message by hints indicating the starting point of a path to a solution. #89733

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

std: Stabilize APIs for the 1.6 release #30187

std: Stabilize APIs for the 1.6 release #30187

alexcrichton commented Dec 3, 2015

rust-highfive commented Dec 3, 2015

alexcrichton commented Dec 3, 2015

bors commented Dec 3, 2015

alexcrichton commented Dec 3, 2015

bors commented Dec 4, 2015

aturon Dec 4, 2015

alexcrichton Dec 4, 2015

aturon commented Dec 4, 2015

alexcrichton commented Dec 4, 2015

bors commented Dec 5, 2015

bors commented Dec 5, 2015

alexcrichton commented Dec 5, 2015

bors commented Dec 5, 2015

bors commented Dec 5, 2015

alexcrichton commented Dec 5, 2015

bors commented Dec 6, 2015

bors commented Dec 6, 2015

bluss commented Dec 6, 2015

bors commented Dec 6, 2015

bors commented Dec 6, 2015

std: Stabilize APIs for the 1.6 release #30187

std: Stabilize APIs for the 1.6 release #30187

Conversation

alexcrichton commented Dec 3, 2015

rust-highfive commented Dec 3, 2015

alexcrichton commented Dec 3, 2015

bors commented Dec 3, 2015

alexcrichton commented Dec 3, 2015

bors commented Dec 4, 2015

aturon Dec 4, 2015

Choose a reason for hiding this comment

alexcrichton Dec 4, 2015

Choose a reason for hiding this comment

aturon commented Dec 4, 2015

alexcrichton commented Dec 4, 2015

bors commented Dec 5, 2015

bors commented Dec 5, 2015

alexcrichton commented Dec 5, 2015

bors commented Dec 5, 2015

bors commented Dec 5, 2015

alexcrichton commented Dec 5, 2015

bors commented Dec 6, 2015

bors commented Dec 6, 2015

bluss commented Dec 6, 2015

bors commented Dec 6, 2015

bors commented Dec 6, 2015