Revert "PR #30130 Implement Clone for more arrays"
#30247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e22a64e. This caused a regression such that types like `[[u8; 256]; 4]` no longer implemented Clone. This previously worked due to Clone for `[T; N]` (N in 0 to 32) being implemented for T: Copy. Due to fixed size arrays not implementing Clone for sizes above 32, the new implementation requiring T: Clone would not allow `[[u8; 256]; 4]` to be Clone.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
I want to be conservative, no unplanned regressions. |
|
cc @tbu- As the original author. |
sfackler
added
the
T-libs-api
|
Yea, revert this for the time being. Theoretically these arrays ought to implement |
|
I propose adding the relevant broken testcase to ease future refactoring efforts. |
|
@untitaker good idea, added test. |
bluss
force-pushed
the
revert-array-clone
branch
from
1db1b67 to
0ca2a9e
Compare
bors
added a commit
that referenced
this pull request
Dec 7, 2015
Revert "PR #30130 Implement `Clone` for more arrays" This reverts commit e22a64e. This caused a regression such that types like `[[u8; 256]; 4]` no longer implemented Clone. This previously worked due to Clone for `[T; N]` (N in 0 to 32) being implemented for T: Copy. Due to fixed size arrays not implementing Clone for sizes above 32, the new implementation requiring T: Clone would not allow `[[u8; 256]; 4]` to be Clone. Fixes #30244 Due to changing back, this is technically a [breaking-change], albeit for a behavior that existed for a very short time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "PR #30130 Implement
Clonefor more arrays"This reverts commit e22a64e.
This caused a regression such that types like
[[u8; 256]; 4]no longer implemented Clone. This previously worked due to Clone
for
[T; N](N in 0 to 32) being implemented for T: Copy.Due to fixed size arrays not implementing Clone for sizes above 32,
the new implementation requiring T: Clone would not allow
[[u8; 256]; 4]to be Clone.Fixes #30244
Due to changing back, this is technically a [breaking-change],
albeit for a behavior that existed for a very short time.