Improve E0401 diagnostics to mention other items #30253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -286,12 +286,32 @@ fn foo<T>(x: T) { | |||
| } | |||
| ``` | |||
|
|
|||
| Functions inside functions are basically just like top-level functions, except | |||
| that they can only be called from the function they are in. | |||
| nor will this | |||
There was a problem hiding this comment.
I think you forgot ':' at the end of your sentence.
Manishearth
force-pushed
the
diag-401-improve
branch
from
148134e to
9dfb81e
Compare
|
fixed |
Manishearth
force-pushed
the
diag-401-improve
branch
from
9dfb81e to
4423463
Compare
|
ping @steveklabnik |
|
@bors: r+ rollup |
|
📌 Commit 4423463 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Dec 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @steveklabnik