move ConstVal -> ValueRef translation to trans::consts #30265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It generally sounds good to me, but I’ve no r-rights, so you’ll have to pick somebody else to review :) |
|
whoops ^^ r? @pnkfelix |
bors
added a commit
that referenced
this pull request
Dec 11, 2015
r? @nagisa I'm going to need the `ConstVal` -> `ValueRef` translation to start removing trans/consts piece by piece. If you need anything implemented in the translation, feel free to assign an issue to me.
nagisa
added a commit
to nagisa/rust
that referenced
this pull request
Dec 28, 2015
This moves back (essentially reverts rust-lang#30265) into MIR-specific translation code, but keeps the funcition split out, since it is expected to eventually become recursive.
nagisa
added a commit
to nagisa/rust
that referenced
this pull request
Dec 31, 2015
…mana This moves back (essentially reverts rust-lang#30265) into MIR-specific translation code, but keeps the funcition split out, since it is expected to eventually become recursive. Fixes rust-lang#29572 cc @oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nagisa
I'm going to need the
ConstVal->ValueReftranslation to start removing trans/consts piece by piece. If you need anything implemented in the translation, feel free to assign an issue to me.