std: Use mem::replace in TLS initialization #30267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
While there is indeed a codegen/soundness bug involving panicking destructors, the root cause of the issue here is that you hold a |
Due to rust-lang#30228 it's not currently sound to do `*ptr = Some(value)`, so instead use `mem::replace` which fixes the soundness hole for now.
alexcrichton
force-pushed
the
tls-init-oh-my
branch
from
8e16eff
to
9e0ff77
Compare
|
@bors r+ |
|
📌 Commit 9e0ff77 has been approved by |
|
⌛ Testing commit 9e0ff77 with merge ce13275... |
bors
added a commit
that referenced
this pull request
Dec 10, 2015
Due to #30228 it's not currently sound to do `*ptr = Some(value)`, so instead use `mem::replace` which fixes the soundness hole for now.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #30228 it's not currently sound to do
*ptr = Some(value), so insteaduse
mem::replacewhich fixes the soundness hole for now.