Skip to content

Undo the backwards incompatable part of the fix for issue #30159 in PR #30294. #30324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/librustc_resolve/resolve_imports.rs
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,9 @@ impl<'a, 'b:'a, 'tcx:'b> ImportResolver<'a, 'b, 'tcx> {
is_public: is_public
};
}
} else {
// FIXME #30159: This is required for backwards compatability.
dest_import_resolution[namespace].is_public |= is_public;
}
};
merge_child_item(ValueNS);
Expand Down
4 changes: 0 additions & 4 deletions src/test/compile-fail/shadowed-use-visibility.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ mod foo {

mod bar {
use foo::bar::f as g; //~ ERROR unresolved import

use foo as f;
pub use foo::*;
}

use bar::f::f; //~ ERROR unresolved import
fn main() {}