Custom help message for people trying to make macro public #30598
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I like it. Opinions @nikomatsakis @Manishearth ? |
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
There was a problem hiding this comment.
This should be a parse-fail test instead?
There was a problem hiding this comment.
I'll move it.
Should I move the files src/test/compile-fail/pub-item-macro.rs and src/test/compile-fail/pub-method-macro.rs too?
There was a problem hiding this comment.
If they deal with errors that come from the parser (looks like they do?), then yes.
|
r=me once the test is moved |
| self.span_err(span, "can't qualify macro invocation with `pub`"); | ||
| self.fileline_help(span, "try adjusting the macro to put `pub` inside \ | ||
| the invocation"); | ||
| let is_macro_rules :bool = match self.token { |
|
@bors r+ |
|
📌 Commit dea7589 has been approved by |
|
☔ The latest upstream changes (presumably #30542) made this pull request unmergeable. Please resolve the merge conflicts. |
The current help message is too much about "normal" macros to be used as general message. Keep it for normal macros, and add custom help and error messages for macro definitions.
est31
force-pushed
the
macro_export_help_note
branch
from
dea7589 to
94434f1
Compare
|
rebased |
|
@bors r+ |
|
📌 Commit 40a9481 has been approved by |
The current help message is too much about "normal" macros to be used as general message. Keep it for normal macros, and add custom help and error messages for macro definitions.
The current help message is too much about "normal" macros to be used
as general message. Keep it for normal macros, and add custom help and
error messages for macro definitions.