Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip coherence checks for error types #30608

Closed
wants to merge 1 commit into from

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Dec 29, 2015

Fix #30589.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Dec 29, 2015

r? @nikomatsakis

@arielb1
Copy link
Contributor

arielb1 commented Dec 29, 2015

I suspect #29954 treats the issue closer to the root.

@sanxiyn
Copy link
Member Author

sanxiyn commented Dec 30, 2015

This is a fallout of #30320. I don't see how #29954 helps. Both ICE says ty_is_local invoked on unexpected type: [type error], but the source of error types is different. There is no unification going on here and the type is an error type from the start because it was undeclared.

@arielb1
Copy link
Contributor

arielb1 commented Dec 30, 2015

@sanxiyn

Didn't notice that you are only working at the outer level. In that case, you probably want to check for trait_ref.references_error() (or self_ty.references_error() for inherent impls) to avoid problems with error types in inner places. r+ modulo that + test that ICEs your current example.

@nikomatsakis
Copy link
Contributor

see also #30676

@bors
Copy link
Contributor

bors commented Jan 11, 2016

☔ The latest upstream changes (presumably #30676) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis
Copy link
Contributor

Closing since this was subsumed into #30676.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants