Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We actually require python 2.7 #30626

Merged
merged 1 commit into from
Jan 14, 2016
Merged

We actually require python 2.7 #30626

merged 1 commit into from
Jan 14, 2016

Conversation

steveklabnik
Copy link
Member

Fixes #30618

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@luqmana
Copy link
Member

luqmana commented Dec 29, 2015

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Dec 29, 2015

📌 Commit cf23dae has been approved by luqmana

@hanna-kruppe
Copy link
Contributor

Over in #30618 doubts have been raised whether we actually require 2.7, perhaps it's prudent to wait for that to be resolved before merging.

If we require 2.7, IMHO the wording should change from "2.7 or later (but not 3.x)" to "2.7 (not 3.x)" since that's slightly clearer. There will never be a Python 2.8, the Python core developers have made that abundantly clear (and unlike the EOL date for 2.7 this has never changed despite many attempts).

@luqmana
Copy link
Member

luqmana commented Dec 30, 2015

@bors r-

@hanna-kruppe
Copy link
Contributor

Not much happened in #30618 but it seems plausible Python 2.7 is actually required. Go ahead and merge this. (Though as mentioned above I'd prefer if the line read "Python 2.7 (not 3.x)".)

@steveklabnik
Copy link
Member Author

@bors: r=luqmana rollup

@bors
Copy link
Contributor

bors commented Jan 12, 2016

📌 Commit cf23dae has been approved by luqmana

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 14, 2016
bors added a commit that referenced this pull request Jan 14, 2016
@bors bors merged commit cf23dae into rust-lang:master Jan 14, 2016
hanna-kruppe pushed a commit to hanna-kruppe/rust that referenced this pull request Feb 13, 2016
In other words, enforce what was documented in rust-lang#30626 (and also stop blaming it on LLVM, we have at least one Python script of our own).

Also, there is no Python later than 2.7 and there never will be.
bors added a commit that referenced this pull request Feb 15, 2016
In other words, enforce what was documented in #30626 (and also stop blaming it on LLVM, we have at least one Python script of our own).

Also, there is no Python later than 2.7 and there never will be.
@steveklabnik steveklabnik deleted the gh30618 branch June 19, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants