Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MinGW details in the README #30698

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Conversation

steveklabnik
Copy link
Member

@@ -88,7 +89,7 @@ Read ["Installing Rust"] from [The Book].
> resulting in a segmentation fault when building Rust. In order to avoid this
> it may be necessary to obtain an earlier version of gcc such as 4.9.x.
> Msys's `pacman` will install the latest version, so for the time being it is
> recommended to skip gcc toolchain installation step above and use [Mingw-Builds]
> recommended to skip gcc toolchain installation step above and use [Mingw-Builds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not intended.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoah, thanks. No idea how that happened.

@retep998
Copy link
Member

retep998 commented Jan 4, 2016

The link on that page takes me to a sourceforge download. I can't say I'm too happy about sourceforge (ublock blocks it saying it is badware), but then again, msys2 has to be obtained through sourceforge as well.

Also, a bit further down, the readme already describes how to obtain an alternate mingw-w64 due to issues with the mingw-w64 provided by msys2. At the very least you could consolidate that with the new information you're providing instead of having two separate somewhat redundant paragraphs.

If you feel up to it, could you add some more information clarifying that mingw-w64 only needs to be installed when building the -gnu targets and that when building the -msvc targets the user needs to have either VS 2013 or VS 2015 with the C++ stuff installed instead. Also the -msvc targets need to have cmake installed to build LLVM. -gnu may need cmake too, I don't know whether we've transitioned to using cmake for LLVM on all targets yet or just -msvc still.

@pitdicker
Copy link
Contributor

It is just a detail, but I was confused whether I should choose the right msys flavor on Sourceforge or in the installer. Can you say "and choose the threads=win32,exceptions=dwarf/seh flavor in the installer"?

@steveklabnik
Copy link
Member Author

Updated! I took some text from the install page.

@retep998
Copy link
Member

retep998 commented Jan 5, 2016

Note that Msys2 still need to be installed, even when building the msvc targets, at least until @alexcrichton 's cargoified version of Rust is ready.

@brson
Copy link
Contributor

brson commented Jan 5, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jan 5, 2016

📌 Commit 011a23e has been approved by brson

@nrc
Copy link
Member

nrc commented Jan 5, 2016

r? @brson (just testing highfive)

@steveklabnik
Copy link
Member Author

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 6, 2016
bors added a commit that referenced this pull request Jan 6, 2016
@bors bors merged commit 011a23e into rust-lang:master Jan 7, 2016
@steveklabnik steveklabnik deleted the gh29649 branch June 19, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants