-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MinGW details in the README #30698
Conversation
@@ -88,7 +89,7 @@ Read ["Installing Rust"] from [The Book]. | |||
> resulting in a segmentation fault when building Rust. In order to avoid this | |||
> it may be necessary to obtain an earlier version of gcc such as 4.9.x. | |||
> Msys's `pacman` will install the latest version, so for the time being it is | |||
> recommended to skip gcc toolchain installation step above and use [Mingw-Builds] | |||
> recommended to skip gcc toolchain installation step above and use [Mingw-Builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoah, thanks. No idea how that happened.
The link on that page takes me to a sourceforge download. I can't say I'm too happy about sourceforge (ublock blocks it saying it is badware), but then again, msys2 has to be obtained through sourceforge as well. Also, a bit further down, the readme already describes how to obtain an alternate mingw-w64 due to issues with the mingw-w64 provided by msys2. At the very least you could consolidate that with the new information you're providing instead of having two separate somewhat redundant paragraphs. If you feel up to it, could you add some more information clarifying that mingw-w64 only needs to be installed when building the |
It is just a detail, but I was confused whether I should choose the right msys flavor on Sourceforge or in the installer. Can you say "and choose the |
Updated! I took some text from the install page. |
Note that Msys2 still need to be installed, even when building the msvc targets, at least until @alexcrichton 's cargoified version of Rust is ready. |
@bors r+ |
📌 Commit 011a23e has been approved by |
r? @brson (just testing highfive) |
@bors: rollup |
Fixes #29649
r? @retep998 @alexcrichton