Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a breaking change in #30523 #30733

Merged
merged 1 commit into from
Jan 6, 2016
Merged

Fix a breaking change in #30523 #30733

merged 1 commit into from
Jan 6, 2016

Conversation

strega-nil
Copy link
Contributor

Fix a breaking change in #30523

While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way

@ubsan
Fix a breaking change in #30523
14e1e2a 
While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@solson
Copy link
Member

solson commented Jan 6, 2016

Note, this was discovered in #30713.

@solson solson mentioned this pull request Jan 6, 2016
Closed
@eddyb
Copy link
Member

eddyb commented Jan 6, 2016

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jan 6, 2016

📌 Commit 14e1e2a has been approved by eddyb

@bors
Copy link
Contributor

bors commented Jan 6, 2016

⌛ Testing commit 14e1e2a with merge e5817d0...

@bors
Copy link
Contributor

bors commented Jan 6, 2016

💔 Test failed - auto-linux-32-opt

@SimonSapin
Copy link
Contributor 

command timed out: 1200 seconds without output running ['make', 'check'], attempting to kill

@pnkfelix
Copy link
Member

pnkfelix commented Jan 6, 2016

@bors retry

@GuillaumeGomez
Copy link
Member

It would be nice to add test which failed with the new version, no?

@nox nox mentioned this pull request Jan 6, 2016
Merged
@bors
Copy link
Contributor

bors commented Jan 6, 2016

⌛ Testing commit 14e1e2a with merge 21b025f...

bors added a commit that referenced this pull request Jan 6, 2016
@bors
Auto merge of #30733 - ubsan:wrapping_op_assign, r=eddyb
21b025f 
Fix a breaking change in #30523

While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way
@bors
Copy link
Contributor

bors commented Jan 6, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 14e1e2a into rust-lang:master Jan 6, 2016
@briansmith briansmith mentioned this pull request Jan 6, 2016
Closed
@brson brson mentioned this pull request Jan 7, 2016
Closed
@nikomatsakis
Copy link
Contributor

It would be good to have a test case, I agree.

@mitchmindtree mitchmindtree mentioned this pull request Jan 9, 2016
Merged
@bvssvni bvssvni mentioned this pull request Jan 9, 2016
Closed
@strega-nil strega-nil deleted the wrapping_op_assign branch September 11, 2018 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@strega-nil @rust-highfive @solson @eddyb @bors @SimonSapin @pnkfelix @GuillaumeGomez @nikomatsakis @ubsan