Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] downgrade struct warn to err #30844

Merged

Conversation

pnkfelix
Copy link
Member

Backport of #30753 to beta branch.

downgrade struct warn to err

Fix #30379 (for real this time).

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@pnkfelix
Copy link
Member Author

r? @nikomatsakis

@pnkfelix
Copy link
Member Author

cc @brson

@pnkfelix pnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 12, 2016
@nikomatsakis
Copy link
Contributor

lgtm. I forget the procedure here though.

@brson
Copy link
Contributor

brson commented Jan 12, 2016

Thanks @pnkfelix. Procedure is to merge manually, then remove 'beta-nominated' from the original PR.

@brson brson closed this Jan 12, 2016
@brson brson reopened this Jan 12, 2016
brson added a commit that referenced this pull request Jan 12, 2016
…ruct-warn-to-err

[beta] downgrade struct warn to err
@brson brson merged commit 4dd6b09 into rust-lang:beta Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants