-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] downgrade struct warn to err #30844
Merged
brson
merged 5 commits into
rust-lang:beta
from
pnkfelix:pr30753-betaport-downgrade-struct-warn-to-err
Jan 12, 2016
Merged
[beta] downgrade struct warn to err #30844
brson
merged 5 commits into
rust-lang:beta
from
pnkfelix:pr30753-betaport-downgrade-struct-warn-to-err
Jan 12, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
cc @brson |
pnkfelix
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Jan 12, 2016
(this makes them handled like enum unit-variants.)
…nd then exit. I think that behavior is fine, so I am removing the expected warnings from these tests.
lgtm. I forget the procedure here though. |
Thanks @pnkfelix. Procedure is to merge manually, then remove 'beta-nominated' from the original PR. |
brson
added a commit
that referenced
this pull request
Jan 12, 2016
…ruct-warn-to-err [beta] downgrade struct warn to err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #30753 to beta branch.
downgrade struct warn to err
Fix #30379 (for real this time).