[beta] Backport fix for issue 29857 #30847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of `TyError` Conflicts: src/test/compile-fail/issue-29857.rs
the problem is that now "type_is_known_to_be_sized" now returns false when called on a type with ty_err inside - this prevents spurious errors (we may want to move the check to check::cast anyway - see rust-lang#12894).
Conflicts: src/test/compile-fail/issue-3973.rs
an error) but the bugfix causes this warning to propagate and become an unresolved variable instead of a `TyError`, so we wind up seeing an obscure inference error afterwards, which is somewhat unfortunate, and suggests this bugfix can cause RFC 1214 warnings to become errors.
|
|
brson
added a commit
that referenced
this pull request
Jan 12, 2016
[beta] Backport fix for issue 29857
|
Thanks @nikomatsakis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #30676. I dropped one commit (the one which removed
ErrorCandidatein favor of resolving to ambiguity) because it wasn't really necessary and I was afraid it may have unexpected complications.Note that one run-pass test stopped working after this backport. This problem did not arise on master because RFC1214 warnings were made into errors, and fixing the RFC1214 problem makes the test work. I ported the fix but this suggests that this backport could cause additional regressions.
r? @brson
cc @arielb1