Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rustdoc reexports #30870

Merged
merged 1 commit into from Jan 14, 2016
Merged

Fix rustdoc reexports #30870

merged 1 commit into from Jan 14, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2016

Fixes #30477, #30213.

The loop over reexports used to be a closure before #30043 but it's an iterator now so it should just continue instead of exiting the loop and skipping stuff.

r? @brson

@alexcrichton
Copy link
Member

@bors: r+ 42acf89

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 13, 2016
@alexcrichton
Copy link
Member

@bors: p=1

@alexcrichton
Copy link
Member

(good candidate to backport)

@brson
Copy link
Contributor

brson commented Jan 13, 2016

Woo! Thanks @eljay

@bors
Copy link
Contributor

bors commented Jan 13, 2016

⌛ Testing commit 42acf89 with merge 1447ce7...

bors added a commit that referenced this pull request Jan 13, 2016
@bors
Auto merge of #30870 - Eljay:issue-30477, r=alexcrichton
1447ce7 
Fixes #30477, #30213.

The loop over reexports used to be a closure before #30043 but it's an iterator now so it should just continue instead of exiting the loop and skipping stuff.

r? @brson
@bors
Copy link
Contributor

bors commented Jan 14, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 42acf89 into rust-lang:master Jan 14, 2016
@brson brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 14, 2016
@brson brson mentioned this pull request Jan 14, 2016
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 14, 2016
@mitaa mitaa mentioned this pull request Jan 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcrichton @brson @bors